Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Federated share activity show 'Decline' action button. #6502

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander
Copy link
Contributor Author

/backport to stable-3.12

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add an automated test for that ?

@allexzander allexzander requested a review from mgallien March 4, 2024 13:01
@allexzander
Copy link
Contributor Author

is it possible to add an automated test for that ?

Added

@mgallien mgallien force-pushed the bugfix/federated-share-activity-actions branch from ba24d24 to 17b0dda Compare March 5, 2024 08:13
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6502-17b0dda3004acd2189d3cda510b27b06e7dfc112-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit b88dfb1 into master Mar 5, 2024
10 of 13 checks passed
@mgallien mgallien deleted the bugfix/federated-share-activity-actions branch March 5, 2024 09:29
@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants